feat(firestore): Exposed more types from the admin.firestore namespace #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Nov 3, 2020
test/integration/firestore.spec.ts
Outdated
| }) | ||
| .then((snapshot: admin.firestore.DocumentSnapshot<City>) => { | ||
| const city: City = snapshot.data()!; | ||
| expect(city).to.deep.equal(expected); |
There was a problem hiding this comment.
FWIW, since you are using converters, you should be able to do an instanceof check here. You would also have to change City to a class.
test/integration/firestore.spec.ts
Outdated
| expect(city).to.deep.equal(expected); | ||
| return refWithConverter.delete(); | ||
| }) | ||
| .should.eventually.be.fulfilled; |
There was a problem hiding this comment.
This last line is a no-op, isn't it?
|
Thanks for adding these! I was lamenting the fact that we have to import types from |
BorntraegerMarc
pushed a commit
to BorntraegerMarc/firebase-admin-node
that referenced
this pull request
Jan 28, 2021
firebase#1080) * feat(firestore): Exposed more types from the admin.firestore namespace * fix: Updated integration test
|
For some reason I still cannot find SnapshotOptions. I didnt see it in the commit either but I did see the others. I think it was missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTE: Exposed a series of new Firestore SDK types from the
admin.firestorenamespace. Newly exposed types includeGrpcStatus,FirestoreDataConverter,UpdateDataand more.RELEASE NOTE: Upgraded the Firestore SDK version to v4.5.0 and higher.
Resolves #1064
Resolves #1074