Handle lookup returning empty array of users. #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
approved these changes
Nov 6, 2020
BorntraegerMarc
pushed a commit
to BorntraegerMarc/firebase-admin-node
that referenced
this pull request
Jan 28, 2021
* Handle lookup returning empty array of users. * Update tests. * Use single quotes. * Update auth-api-request.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
This is a follow up to #1078 and improves the detection to be more robust for detecting no users returned.
Previously, it depends on
.usersnot being present (instead of an empty array) when there are no users. This is not explicitly part of the API documentation or contract and we probably shouldn't depend on it.Testing
API Changes
No public API changes included.