Skip to content

A Few Additional Tests for RTDB Support #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 8, 2017
Merged

A Few Additional Tests for RTDB Support #131

merged 12 commits into from
Nov 8, 2017

Conversation

hiranya911
Copy link
Contributor

Adding some sanity checks, especially around the new multi DB support.

Also added a new type definition for EventType (as a temporary workaround until firebase/firebase-js-sdk#306 gets fixed).

Copy link

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 assigned hiranya911 and unassigned jshcrowthe Nov 8, 2017
@hiranya911 hiranya911 merged commit a8e5b96 into master Nov 8, 2017
@hiranya911 hiranya911 deleted the hkj-rtdb-update branch November 8, 2017 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants