Remove request body for deleteTenant #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Oct 12, 2021
hiranya911
added a commit
that referenced
this pull request
Oct 12, 2021
This reverts commit 475927c.
hiranya911
added a commit
that referenced
this pull request
Oct 12, 2021
lisajian
added a commit
to lisajian/firebase-admin-node
that referenced
this pull request
Oct 13, 2021
lisajian
added a commit
to lisajian/firebase-admin-node
that referenced
this pull request
Oct 13, 2021
lisajian
added a commit
to lisajian/firebase-admin-node
that referenced
this pull request
Oct 14, 2021
lisajian
added a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Delete endpoints should not have a body in the request (see https://google.aip.dev/135). Currently running into issues with running
deleteTenant()integration test against the emulator because a body is passed into the request. This issue will also be present for other delete endpoints but is not addressed in this PR.firebase/firebase-tools#3818 also addresses the issue from the emulator side, but Admin SDK should not pass in body to delete endpoints in general.
Corresponding internal bug: b/192387245
Testing
npm testpassesAPI Changes
N/A