Scaffolding out extensions namespace #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
LGTM! Thank you @joehan !
I added a few nit-picking comments below.
| @@ -0,0 +1,39 @@ | |||
| /*! | |||
| * @license | |||
| * Copyright 2021 Google Inc. | |||
There was a problem hiding this comment.
nit: should this be 2022?
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
| import { FirebaseApp } from '../app/firebase-app'; | ||
| import { HttpClient, AuthorizedHttpClient } from '../utils/api-request'; | ||
| import { FirebaseAppError } from '../utils/error'; | ||
| import * as validator from '../utils/validator'; |
| @@ -0,0 +1,16 @@ | |||
| /*! | |||
| * @license | |||
| * Copyright 2021 Google Inc. | |||
There was a problem hiding this comment.
nit: Should this be 2022?
| const firebaseApp: FirebaseApp = app as FirebaseApp; | ||
| return firebaseApp.getOrInitService('extensions', (app) => new Extensions(app)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for catching these - gonna fix them in #1838 since they're all small style things
joehan
added a commit
that referenced
this pull request
Nov 16, 2022
* Scaffolding out extensions namespace (#1829) * starting scaffolding * Finish scaffolding extensions * adding whitespace * Implements Extensions namespace (#1838) * starting scaffolding * Finish scaffolding extensions * adding whitespace * Implements Extensions namespace * Expose extensions module * fixing api-extractor by adding @internal * Improve error handling * lint * Add jsdocsand api-extract * merging * style fixes from 1829 * style fix * Addressing PR comments * Clean up getRuntimeData * typo fix * in the tests as well * PR fixes * round 2 of fixes * PR fixes * Update src/extensions/extensions.ts Co-authored-by: Kevin Cheung <[email protected]> * Update src/extensions/extensions.ts Co-authored-by: Kevin Cheung <[email protected]> * Update src/extensions/extensions.ts Co-authored-by: Kevin Cheung <[email protected]> * Update src/extensions/extensions.ts Co-authored-by: Kevin Cheung <[email protected]> * Docs pass * lint * Fix test Co-authored-by: Kevin Cheung <[email protected]> Co-authored-by: Kevin Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffolding out the files for the extensions namespace described in go/firex-admin-sdk. Most of the real business logic for this is implemented in #1838 - I just split this out to keep things a bit more manageable for review.
DO NOT MERGE yet