feat(auth): Support sms region config change on Tenant and Project level #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renkelvin
reviewed
Oct 5, 2022
renkelvin
approved these changes
Oct 6, 2022
|
Hey @lahirumaramba, we're releasing the SMS regions in the admin sdk given the launch is now approved. Most of the changes were reviewed here: #1673. It was merged then reverted. Please take a look and feel free to let us know if there is any questions. Thanks! |
lahirumaramba
changed the title
lahirumaramba
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Thank you @pragatimodi and @renkelvin! LGTM!
Merging this to the main branch will include the feature in the next SDK release... If we need more time to release this change we can merge this to a feature branch for now. Let me know.
Thanks @lahirumaramba ! Yeah, we'd like to include this feature in the next SDK release. |
pragatimodi
added a commit
that referenced
this pull request
Oct 21, 2022
* [chore] Release 11.1.0 (#1914) * feat(auth): Support sms region config change on Tenant and Project level (#1921) * api proposal sms draft * support SMS regions config update for project and tenant * fix lint issues * remove reCAPTCHA related docs and variable names * Address PR feedbacks * removed the unnecessary optional tag * updated the validation parameter type * update the doc * Fixing some problems that failed build 14.x and 16.x * Undoing package-lock.json changes * Reverting package-lock.json changes Co-authored-by: Liubin Jiang <[email protected]> Co-authored-by: Liubin Jiang <[email protected]> * build(deps-dev): bump yargs from 17.5.1 to 17.6.0 (#1917) Bumps [yargs](https://github.com/yargs/yargs) from 17.5.1 to 17.6.0. - [Release notes](https://github.com/yargs/yargs/releases) - [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md) - [Commits](yargs/yargs@v17.5.1...v17.6.0) --- updated-dependencies: - dependency-name: yargs dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/mocha from 9.1.1 to 10.0.0 (#1919) * build(deps-dev): bump @typescript-eslint/parser from 5.38.1 to 5.40.0 (#1926) * build(deps-dev): bump @typescript-eslint/eslint-plugin (#1927) * build(deps): bump @firebase/database-compat from 0.2.6 to 0.2.7 (#1928) Bumps [@firebase/database-compat](https://github.com/firebase/firebase-js-sdk/tree/HEAD/packages/database-compat) from 0.2.6 to 0.2.7. - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/packages/database-compat/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/commits/@firebase/[email protected]/packages/database-compat) --- updated-dependencies: - dependency-name: "@firebase/database-compat" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump minimist from 1.2.6 to 1.2.7 (#1930) * build(deps): bump jwks-rsa from 2.1.4 to 2.1.5 (#1931) * build(deps-dev): bump @microsoft/api-extractor from 7.31.2 to 7.33.1 (#1935) * build(deps-dev): bump bcrypt from 5.0.1 to 5.1.0 (#1934) * build(deps): bump @firebase/database-types from 0.9.13 to 0.9.16 (#1932) * build(deps-dev): bump @firebase/app-compat from 0.1.34 to 0.1.37 (#1937) Bumps [@firebase/app-compat](https://github.com/firebase/firebase-js-sdk/tree/HEAD/packages/app-compat) from 0.1.34 to 0.1.37. - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/packages/app-compat/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/commits/@firebase/[email protected]/packages/app-compat) --- updated-dependencies: - dependency-name: "@firebase/app-compat" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @firebase/database-compat from 0.2.7 to 0.2.9 (#1940) * build(deps-dev): bump @microsoft/api-extractor from 7.33.1 to 7.33.2 (#1939) * build(deps-dev): bump sinon from 14.0.0 to 14.0.1 (#1938) * chore(fs): Upgrade firestore dependency (#1941) Upgrade @google-cloud/firestore dependency to v6.4.0 * [chore] Release 11.2.0 (#1942) * build(deps-dev): bump @typescript-eslint/eslint-plugin (#1943) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.40.0 to 5.40.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump mocha from 10.0.0 to 10.1.0 (#1944) * build(deps-dev): bump @microsoft/api-extractor from 7.33.2 to 7.33.4 (#1946) Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack/tree/HEAD/apps/api-extractor) from 7.33.2 to 7.33.4. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Changelog](https://github.com/microsoft/rushstack/blob/main/apps/api-extractor/CHANGELOG.md) - [Commits](https://github.com/microsoft/rushstack/commits/@microsoft/api-extractor_v7.33.4/apps/api-extractor) --- updated-dependencies: - dependency-name: "@microsoft/api-extractor" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(fcm): Increase FCM timeout to 15s (#1947) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Lahiru Maramba <[email protected]> Co-authored-by: Liubin Jiang <[email protected]> Co-authored-by: Liubin Jiang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for SMS Region
Original PR here : https://github.com/firebase/firebase-admin-node/pull/1673/files