-
Notifications
You must be signed in to change notification settings - Fork 391
Extensions TSDoc edits #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Extensions TSDoc edits #1982
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,14 +16,22 @@ | |
*/ | ||
|
||
/** | ||
* SettableProcessingState represents all the Processing states that can be set on an ExtensionInstance's runtimeData. | ||
* SettableProcessingState represents all the Processing states that can be set | ||
* on an Extension instance's runtimeData. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should |
||
* | ||
* @remarks | ||
* - NONE: No relevant lifecycle event work has been done. Set this to clear out old statuses. | ||
* | ||
* - PROCESSING_COMPLETE: Lifecycle event work completed with no errors. | ||
* | ||
* - PROCESSING_WARNING: Lifecycle event work succeeded partially, | ||
* or something happened that the user should be warned about. | ||
* | ||
* - PROCESSING_FAILED: Lifecycle event work failed completely, | ||
kevinthecheung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* but the instance will still work correctly going forward. | ||
* - If the extension instance is in a broken state due to the errors, instead set FatalError. | ||
* | ||
* - If the extension instance is in a broken state due to errors, instead set FatalError. | ||
kevinthecheung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* | ||
* - To report ongoing (non-final) status, use `console.log` or the Cloud Functions logger SDK. | ||
*/ | ||
export type SettableProcessingState = 'NONE' | 'PROCESSING_COMPLETE' | 'PROCESSING_WARNING' | 'PROCESSING_FAILED'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.