Validating the private key string #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
approved these changes
May 9, 2017
jshcrowthe
approved these changes
May 10, 2017
There was a problem hiding this comment.
This LGTM 👍 In testing this I discovered that this repo doesn't have a test script to test the repo. We will need to get that implemented.
For reference: https://docs.npmjs.com/misc/scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the admin SDK can be initialized with an invalid private key. The error won't be caught until we try to make an API request using the key, at which point the error would manifest as a server side error:
This fix parses the private key field when the certificate credential is initialized, and presents the user with a more meaningful error:
I had to bring in node-forge as a dependency to parse private key in PEM. Not sure if that's the best thing to do here. Appreciate any feedback on that.