Skip to content

Allow DataSnapshot.forEach to return void #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Conversation

sprmn
Copy link
Contributor

@sprmn sprmn commented Nov 15, 2018

The forEach method on a DataSnapshot should be able to return void, as shown in the example in the docs.

Related to firebase/firebase-js-sdk#555

@hiranya911 hiranya911 merged commit 616037d into firebase:master Nov 16, 2018
@sprmn sprmn deleted the patch-1 branch November 23, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants