Skip to content

Fixing Android notification options descriptions #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Fixing Android notification options descriptions #820

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75d49a1
Fixing doc bug that conflated sound and tag options for Android notif…
egilmorez Mar 16, 2020
5cb9955
Removing duplicate documentation for tag.
egilmorez Mar 16, 2020
70e1793
Adding tag details in the right place this time, hopefully.
egilmorez Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4616,7 +4616,14 @@ declare namespace admin.messaging {
silent?: boolean;

/**
* An identifying tag for the notification.
* Identifier used to replace existing notifications in the notification drawer.
*
* If not specified, each request creates a new notification.
*
* If specified and a notification with the same tag is already being shown,
* the new notification replaces the existing one in the notification drawer.
*
* **Platforms:** Android
*/
tag?: string;

Expand Down Expand Up @@ -4700,13 +4707,10 @@ declare namespace admin.messaging {
color?: string;

/**
* Identifier used to replace existing notifications in the notification drawer.
*
* If not specified, each request creates a new notification.
*
* If specified and a notification with the same tag is already being shown,
* the new notification replaces the existing one in the notification drawer.
*
* The sound to play when the device receives the notification. Supports
* "default" or the filename of a sound resource bundled in the app. Sound files
* must reside in `/res/raw/`.
*
* **Platforms:** Android
*/
sound?: string;
Expand Down