-
Notifications
You must be signed in to change notification settings - Fork 390
feat(auth): Adds ability to enable MFA on a Google Cloud Identity Platform tenant #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6cefbdd
feat(auth): Adds ability to enable MFA on a tenant.
bojeil-google f36e14f
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 9e6be07
Addresses review comments.
bojeil-google 751890a
Switch to using array instead of set for terminalPaths.
bojeil-google 1d37768
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 1fdb4e1
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 7f7085f
Adds additional edge case test for building MFA config HTTP request.
bojeil-google db8238a
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 1cc5670
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 56c7162
Adds integration test for clearing the map of test phone numbers.
bojeil-google c8f94b2
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 3334ade
Merge branch 'master' into multi-tenancy-mfa
bojeil-google 7ed6455
Fix linter issue.
bojeil-google d591726
Adds MultiFactorConfig to docgen/content-sources/node/toc.yaml
bojeil-google 2a87b64
Merge branch 'master' into multi-tenancy-mfa
bojeil-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need to be a top-level function in this module. Doesn't look like it belongs in this class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This follows the same pattern as other config classes here. Personally, I think this is an adequate place for it. If you don't agree, I think we should then refactor the other config classes here in a separate PR to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Let's do that refactor in a future PR.