Skip to content

chore: Add ESLint rule for curly braces, apply fix #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2020
Merged

chore: Add ESLint rule for curly braces, apply fix #939

merged 2 commits into from
Jul 10, 2020

Conversation

MathBunny
Copy link
Contributor

  • Added ESLint rule for curly braces (used for imports/exports, object literals, destructuring assignment)
  • Applied fix using ESLint --fix parameter

hiranya911
hiranya911 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 removed their assignment Jul 9, 2020
lahirumaramba
lahirumaramba approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathBunny MathBunny merged commit 1b283e3 into master Jul 10, 2020
@MathBunny MathBunny removed their assignment Jul 10, 2020
@MathBunny MathBunny deleted the hlazu-curly-braces-lint branch July 13, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathBunny @lahirumaramba @hiranya911