Skip to content

FirebaseML - adding Long Running Operation support #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2020
Merged

FirebaseML - adding Long Running Operation support #951

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edd48dd
FirebaseML - adding Long Running Operation support
ifielker Jul 15, 2020
2404911
review changes
ifielker Jul 17, 2020
49e4aab
review comments 2
ifielker Jul 20, 2020
ccbf8da
review comments 3
ifielker Jul 21, 2020
3b4d469
review comments 4
ifielker Jul 22, 2020
66a8f8c
review comments 5
ifielker Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 32 additions & 23 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"optionalDependencies": {
"@google-cloud/firestore": "^4.0.0",
"@google-cloud/storage": "^5.0.0"
"@google-cloud/storage": "^5.1.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was, I just installed the latest, I guess it changed this file too. I'll revert.

},
"devDependencies": {
"@firebase/app": "^0.6.1",
Expand Down
Loading