chore: Remove instances of XXX_SDK_VERSION_XXX by reading version from package.json #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathBunny
changed the title
hiranya911
suggested changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes instances of
XXX_SDK_VERSION_XXXwhich were substituted by gulp at the build stage, and instead reads frompackage.jsonthe value ofversion.Test Plan
Added unit test to verify that the value is read from
package.json.Edit: I had a thought of perhaps adding an integration test to it or for the
example.test.ts, however this is a util function which isn't supposed to be exposed to developers hence my initial reaction was against that.