Skip to content

Allow instance-id to auto-generate typings, separate internal vs external APIs #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 30, 2020

Conversation

MathBunny
Copy link
Contributor

Unfortunately, I merged the previously approved #965 into the wrong branch as I forgot to change the target before merging. Otherwise, this is an identical PR.

Side-note: If you merge a PR, and then revert, you cannot re-open the PR like you can for issues (lesson learned).


Context

The goal is to bridge the gap between today's Admin SDK (manually curated d.ts files, nested namespaces) and a modularized SDK that has auto-generated typings.

This is the second milestone from: go/firebase-node-auto-typing.

Goals for this PR

  1. Allow to auto-generated typings for instance-id
  2. Split the internal and external APIs
  3. Still use the previous manually curated typings
  4. Be a non-breaking change

Prerequisites

The intention for this PR is to be merged after RTDB modularization.
The gulpfile PR from hlazu-modularizing-gulpfile.

Test Plan

  1. Unit tests:

npm test

  1. Integration tests:

export TYPE_GENERATION_MODE=nonauto && npm run integration && export TYPE_GENERATION_MODE=auto && npm run integration

  1. Sanity tests:

export TYPE_GENERATION_MODE=nonauto && npm pack && ./.github/scripts/verify_package.sh firebase-* && export TYPE_GENERATION_MODE=auto && npm pack && ./.github/scripts/verify_package.sh firebase-*

@MathBunny MathBunny requested a review from hiranya911 July 30, 2020 02:33
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathBunny MathBunny merged commit 031edc2 into master Jul 30, 2020
@MathBunny MathBunny deleted the hlazu-modularizing-instance-id branch August 4, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants