Skip to content

Allow security-rules to auto-generate typings, separate internal vs external APIs #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 6, 2020
Merged

Allow security-rules to auto-generate typings, separate internal vs external APIs #974

merged 9 commits into from
Aug 6, 2020

Conversation

MathBunny
Copy link
Contributor

Context

The goal is to bridge the gap between today's Admin SDK (manually curated d.ts files, nested namespaces) and a modularized SDK that has auto-generated typings.

This is the fourth milestone from: go/firebase-node-auto-typing.

Goals for this PR

  1. Allow to auto-generated typings for security-rules
  2. Split the internal and external APIs
  3. Still use the previous manually curated typings
  4. Be a non-breaking change

Prerequisites

None.

Test Plan

  1. Unit tests:

npm test

  1. Integration tests:

export TYPE_GENERATION_MODE=nonauto && npm run integration && export TYPE_GENERATION_MODE=auto && npm run integration

  1. Sanity tests:

export TYPE_GENERATION_MODE=nonauto && npm pack && ./.github/scripts/verify_package.sh firebase-* && export TYPE_GENERATION_MODE=auto && npm pack && ./.github/scripts/verify_package.sh firebase-*

@MathBunny MathBunny marked this pull request as ready for review July 31, 2020 22:25
@MathBunny MathBunny requested a review from hiranya911 August 5, 2020 20:54
hiranya911
hiranya911 suggested changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just one suggestion. Also sync up with the latest state of the master branch.

@hiranya911 hiranya911 assigned MathBunny and unassigned hiranya911 Aug 5, 2020
@MathBunny MathBunny requested a review from hiranya911 August 6, 2020 15:31
@MathBunny MathBunny assigned hiranya911 and unassigned MathBunny Aug 6, 2020
hiranya911
hiranya911 approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned MathBunny and unassigned hiranya911 Aug 6, 2020
@MathBunny MathBunny merged commit 1984f1f into master Aug 6, 2020
@MathBunny MathBunny deleted the hlazu-modularizing-security-rules branch August 12, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@MathBunny MathBunny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathBunny @hiranya911