Skip to content

chore(rc): Move manual typings remote-config typings to separate folder #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2020

Conversation

MathBunny
Copy link
Contributor

Context

As part of the initiative to auto-generate typings, it would be easier to verify that they are correctly generated if the remote-config manually curated typings were in another file. As part of the gulpfile build process, we could simply ignore the d.ts file.

Solution

Moved the contents to a separate file, following the practice used by many of the other services today.

Test Plan

  1. Ran unit, integration and sanity tests.
  2. Manually generated the docs, performed quick manual inspection, links work locally (excluding the index).

@MathBunny MathBunny marked this pull request as ready for review July 31, 2020 18:36
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Aug 4, 2020
@lahirumaramba
Copy link
Member

Adding release:stage label to run integration tests.

@MathBunny
Copy link
Contributor Author

Thank you!

@MathBunny MathBunny merged commit 646d90f into master Aug 4, 2020
@MathBunny MathBunny deleted the hlazu-rc-typings branch August 12, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants