-
Notifications
You must be signed in to change notification settings - Fork 391
Allow FCM to auto-generate typings, separate internal vs external APIs #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
restrictedPackageName?: string; | ||
[other: string]: any; | ||
[key: string]: any | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Just one change suggestion. Shouldn't we also need to modify the gulp file?
Thanks for the feedback! Yes, I missed adding it to the gulpfile, that is required. Moreover, after running the sanity tests with the updated gulpfile it also uncovered a missing interface that wasn't exported 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit.
Context
The goal is to bridge the gap between today's Admin SDK (manually curated d.ts files, nested namespaces) and a modularized SDK that has auto-generated typings.
This is the sixth milestone from:
go/firebase-node-auto-typing
.Goals for this PR
Prerequisites
None.
Test Plan