Allow RemoteConfig to auto-generate typings, separate internal vs external APIs #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
Aug 10, 2020
There was a problem hiding this comment.
Looks good. Just one suggestion from me. Please wait for @lahirumaramba to review.
| RemoteConfigTemplate, | ||
| TagColor, | ||
| ListVersionsResult, | ||
| Version, | ||
| } from '../../../src/remote-config/remote-config-api-client'; | ||
| import { FirebaseRemoteConfigError } from '../../../src/remote-config/remote-config-utils'; | ||
| import { RemoteConfigApiClient } from '../../../src/remote-config/remote-config-api-client-internal'; | ||
| import { FirebaseRemoteConfigError } from '../../../src/remote-config/remote-config-utils-internal'; |
There was a problem hiding this comment.
Just remote-config-internal. Or just move into the remote-config-api-client-internal module. *-utils-internal is an unusual name.
There was a problem hiding this comment.
Yeah. remote-config-utils only contains FirebaseRemoteConfigError and error codes. We should be able to move it into remote-config-api-client-internal
lahirumaramba
approved these changes
Aug 10, 2020
| RemoteConfigTemplate, | ||
| TagColor, | ||
| ListVersionsResult, | ||
| Version, | ||
| } from '../../../src/remote-config/remote-config-api-client'; | ||
| import { FirebaseRemoteConfigError } from '../../../src/remote-config/remote-config-utils'; | ||
| import { RemoteConfigApiClient } from '../../../src/remote-config/remote-config-api-client-internal'; | ||
| import { FirebaseRemoteConfigError } from '../../../src/remote-config/remote-config-utils-internal'; |
There was a problem hiding this comment.
Yeah. remote-config-utils only contains FirebaseRemoteConfigError and error codes. We should be able to move it into remote-config-api-client-internal
lahirumaramba
requested changes
Aug 10, 2020
|
Thanks for the feedback, PTAL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The goal is to bridge the gap between today's Admin SDK (manually curated d.ts files, nested namespaces) and a modularized SDK that has auto-generated typings.
This is the seventh milestone from:
go/firebase-node-auto-typing.Goals for this PR
Prerequisites
None.
Test Plan