Allow Firestore to auto-generate typings, separate internal vs external APIs #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
reviewed
Aug 11, 2020
src/firestore/firestore-internal.ts
Outdated
|
|
||
| import * as validator from '../utils/validator'; | ||
| import * as utils from '../utils/index'; | ||
|
|
||
| export function getFirestoreOptions(app: FirebaseApp): Settings { |
There was a problem hiding this comment.
Why does this file contain code changes?
There was a problem hiding this comment.
Sorry, it shouldn't have any changes. I had originally put some code in firestore.ts, but after realizing it wasn't necessary and adding it back in a different order polluted the diff. Fixed.
|
Thanks for the feedback. Also, for visibility, the Firestore service will require manual re-exporting in the barrel export even past this project because of the previous issue we ran into when prototyping this in #948 with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The goal is to bridge the gap between today's Admin SDK (manually curated d.ts files, nested namespaces) and a modularized SDK that has auto-generated typings.
This is the eighth milestone from:
go/firebase-node-auto-typing.Goals for this PR
Prerequisites
None.
Test Plan