Firebase ML can gracefully ignore unknown fields in ModelResponse #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
This LGTM. Assigning to @lahirumaramba who's in the middle of a release to determine when this can be landed.
|
@ifielker @hiranya911 We can including this in the upcoming release. Does this change contain release-notes? |
|
There are no release notes for this. Users are not affected, and it doesn't fix any issues that users have seen. It's future proofing so users don't have any issues going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase ML can gracefully ignore unknown fields in ModelResponse.