Skip to content

Upgraded cachecontrol to latest #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Upgraded cachecontrol to latest #378

merged 2 commits into from
Jan 3, 2020

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Dec 23, 2019

Resolves #377

Also fixed some unit tests that started failing unexpectedly. It seems requests is now setting the timeout as a float value.

RELEASE NOTE: Upgraded the cachecontrol dependency to the latest available.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hiranya!
LGTM!

@hiranya911 hiranya911 merged commit 81463e2 into master Jan 3, 2020
@hiranya911 hiranya911 deleted the hkj-cachecontrol branch January 3, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporting error caused by dependencies on external libararies: "cachecontrol" and "msgpack"
2 participants