chore: Create a GitHub Actions based CI Pipeline #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
changed the title
yuchenshi
approved these changes
Jan 14, 2020
| node-version: 10.x | ||
| - name: Run integration tests against emulator | ||
| run: | | ||
| npm install -g firebase-tools |
There was a problem hiding this comment.
I think we should use https://firebase.tools instead so that we can drop the setup-node action and build faster, but I think this is fine for now as well. Also, have we considered caching ~/.cache/firebase which contains the emulator and (later) the standalone CLI?
There was a problem hiding this comment.
Been experimenting with this, but firebase.tools absolutely refuses to work in the GitHub Actions environment (filed a bug for the CLI for this). There are bunch of workarounds I can use to get this to work -- which involves pulling the CLI binary for Linux explicitly. But I'd rather do all that in a separate PR.
lahirumaramba
approved these changes
Jan 15, 2020
hiranya911
force-pushed
the
hkj-actions
branch
from
60d2288 to
dd276ef
Compare
hiranya911
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved CI tasks to GitHub Actions. Kept the Travis CI job for testing on Py3.4, as that's not supported in GitHub Actions. Hopefully we can get rid of it completely once googleapis/google-cloud-python#10136 is addressed.