Skip to content

Defined linter as a separate job #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 30, 2020
Merged

Defined linter as a separate job #398

merged 7 commits into from
Jan 30, 2020

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Jan 29, 2020

Currently the linter task is part of the Python 3.7 test task, which makes interpreting build results complicated. This PR defines the linter as a separate independent job.

Also turning fail-fast off in the build matrix, so that test failures in one Python version don't cancel other test runs.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@hiranya911 hiranya911 merged commit ffebd3c into master Jan 30, 2020
@hiranya911 hiranya911 deleted the hkj-lint branch January 30, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants