Skip to content

chore: Experimental GitHub Actions based workflow for publishing releases #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2020
Merged

chore: Experimental GitHub Actions based workflow for publishing releases #402

merged 4 commits into from
Feb 6, 2020

Conversation

hiranya911
Copy link
Contributor

  • Handles everything including running the tests, creating the tag, publishing to Pypi and posting to Twitter.
  • Build artifacts are also attached to the workflow log. These can be downloaded for manual inspection or testing.
  • A developer can request to stage a build by adding the "release:build" label to any PR (or by sending a repository dispatch event). This is useful for building RCs for testing.
  • The actual release PR must be on the master branch and have the title prefix [chore] Release in addition to the build label.

lahirumaramba
lahirumaramba reviewed Feb 6, 2020
View reviewed changes
.github/workflows/release.yml

- name: Publish to Pypi
if: success() && env.FIREBASE_PUBLISH
run: echo Publishing to Pypi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these actions needs to be implemented in future PRs, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the plan.

lahirumaramba
lahirumaramba approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

This PR doesn't including publishing to Pypi and posting to twitter yet, right? It has everything else to handle those actions though

@hiranya911 hiranya911 merged commit 57f1603 into master Feb 6, 2020
@hiranya911 hiranya911 deleted the hkj-release-flow branch February 6, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @lahirumaramba