Skip to content

fix(auth): Fixed some API reference mistakes #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2020
Merged

fix(auth): Fixed some API reference mistakes #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440bdeb
fix(auth): Fixed some API reference mistakes
hiranya911 Apr 28, 2020
9490b0f
Fixed astroid version to avoid lint error
hiranya911 Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion firebase_admin/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
'ActionCodeSettings',
'CertificateFetchError',
'Client',
'ConfigurationNotFoundError',
'DELETE_ATTRIBUTE',
'EmailAlreadyExistsError',
'ErrorInfo',
Expand All @@ -48,6 +49,7 @@
'InvalidSessionCookieError',
'ListProviderConfigsPage',
'ListUsersPage',
'OIDCProviderConfig',
'PhoneNumberAlreadyExistsError',
'ProviderConfig',
'RevokedIdTokenError',
Expand All @@ -65,14 +67,17 @@
'UserRecord',

'create_custom_token',
'create_oidc_provider_config',
'create_saml_provider_config',
'create_session_cookie',
'create_user',
'delete_oidc_provider_config',
'delete_saml_provider_config',
'delete_user',
'generate_email_verification_link',
'generate_password_reset_link',
'generate_sign_in_with_email_link',
'get_oidc_provider_config',
'get_saml_provider_config',
'get_user',
'get_user_by_email',
Expand All @@ -82,6 +87,7 @@
'list_users',
'revoke_refresh_tokens',
'set_custom_user_claims',
'update_oidc_provider_config',
'update_saml_provider_config',
'update_user',
'verify_id_token',
Expand All @@ -107,7 +113,7 @@
ListUsersPage = _user_mgt.ListUsersPage
OIDCProviderConfig = _auth_providers.OIDCProviderConfig
PhoneNumberAlreadyExistsError = _auth_utils.PhoneNumberAlreadyExistsError
ProviderConfig = _auth_providers.ProviderConfigClient
ProviderConfig = _auth_providers.ProviderConfig
RevokedIdTokenError = _token_gen.RevokedIdTokenError
RevokedSessionCookieError = _token_gen.RevokedSessionCookieError
SAMLProviderConfig = _auth_providers.SAMLProviderConfig
Expand Down
2 changes: 1 addition & 1 deletion firebase_admin/ml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def list_models(list_filter=None, page_size=None, page_token=None, app=None):
"""Lists models from Firebase ML.

Args:
list_filter: a list filter string such as "tags:'tag_1'". None will return all models.
list_filter: a list filter string such as ``tags:'tag_1'``. None will return all models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

page_size: A number between 1 and 100 inclusive that specifies the maximum
number of models to return per page. None for default.
page_token: A next page token returned from a previous page of results. None
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
astroid == 2.3.3
pylint == 2.3.1
pytest >= 3.6.0
pytest-cov >= 2.4.0
Expand Down