Some Minor Fixes to Integration Tests #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authmodules are binary typed (i.e.strin Python 2.x andbytesin Python 3.x). Therefore in Python 3.x they need to be decoded before they can be put into a JSON structure. This was causing a test failure in Python 3.x (see Fix Integration Tests for Python 3.x #37). This patch fixes it.dbintegration test was only updating the security rules for a specific child node (_adminsdk). But as it turns out, in Firebase RTDB shallow rules take precedence. This means if there's already a shallow rule configured in the target database, the integration tests can fail (see Fix Rule Set Up in Integration Tests #45). This patch fixes it by overwriting the entire rules configuration in the test fixture.