Skip to content

Adds integration tests for the Async Firstore module #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2022

Conversation

jkyle109
Copy link
Contributor

Adds integration tests for the async Firstore module.

Related to #104

@jkyle109 jkyle109 self-assigned this Jul 13, 2022
@jkyle109 jkyle109 marked this pull request as ready for review July 14, 2022 14:29
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Jul 14, 2022
@lahirumaramba
Copy link
Member

Added staging label to trigger integration tests

@jkyle109 jkyle109 merged commit eb8226b into async-firestore Jul 14, 2022
@jkyle109 jkyle109 deleted the je-async-fs-int branch July 26, 2022 15:51
jkyle109 added a commit that referenced this pull request Aug 24, 2022
* feat(firestore): Expose Async Firestore Client. (#621)

* feat(firestore): Expose Async Firestore Client.

* fix: Added type hints and defintion wording changes

* fix: removed future annotations until Python 3.6 is depreciated.

* fix: added missed type and clarifying comment for Python 3.6 type hinting.

* fix: lint

* Adds integration tests for the Async Firstore module (#623)

* Add integration tests for async firstore module

* fix: made pytest Python 3.6 compatible

* Trigger Integration Tests

* fix: correct copyright year

* Add code snippets for firestore modules. (#628)

* Add code snippets for firestore modules.

* fix: clarified snippet names and fixed newline.

* fix: Removed var tags. These won't work as I intended it to since html is escaped when using includecode.

Co-authored-by: Lahiru Maramba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants