Skip to content

Add Offset logline #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

Add Offset logline #3417

merged 1 commit into from
Feb 8, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 7, 2022 •
edited
Loading

This shows how far the index has advanced.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.52% (ea9775b) to 45.52% (a576881) by +0.01%.

    FilenameBase (ea9775b)Merge (a576881)Diff
    IndexBackfiller.java76.19%76.56%+0.37%
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

Notes

  • Commit (a576881) is created by Prow via merging PR base commit (ea9775b) and head commit (17fcb4d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6mNaTwaym2.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ea9775b)Merge (a576881)Diff
    aar1.24 MB1.24 MB+20 B (+0.0%)
    apk (release)3.33 MB3.33 MB-112 B (-0.0%)

Test Logs

Notes

  • Commit (a576881) is created by Prow via merging PR base commit (ea9775b) and head commit (17fcb4d).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WW95cBa6jC.html

@schmidt-sebastian schmidt-sebastian merged commit 149529a into master Feb 8, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/offsetlog branch February 8, 2022 17:51
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@schmidt-sebastian @jeremyjiang-dev
Offset logline (#3417)
b7aeecb
@firebase firebase locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @ehsannas