Skip to content

Fix flaky PerfSessionTest due to async access to SharedPrefs #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

raymondlam
Copy link
Member

shouldCollectGaugesAndEvents_perfMonDisabledAtRuntime_sessionNotVerbose occasionally fails when it tries to programmatically set the config. This is likely due to the ConfigResolver trying to setValue before the shared preferences is ready.

This just forces the test to use a single threaded FakeDirectExecutorService for the DeviceCacheManager

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (ea9775b) and merge commit (5692961).

Test Logs

Notes

  • Commit (5692961) is created by Prow via merging PR base commit (ea9775b) and head commit (5ec8fb1).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rKB2adPxkx.html

@google-oss-bot
Copy link
Contributor

@raymondlam raymondlam merged commit 7657acf into firebase:master Feb 8, 2022
@raymondlam raymondlam deleted the fixFlakySessionTest branch February 8, 2022 00:55
@firebase firebase locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants