Skip to content

Parse Overlays in background #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2022
Merged

Parse Overlays in background #3420

merged 5 commits into from
Feb 10, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 8, 2022 •
edited
Loading

WIth indexing, we frequently look up Overlays by key. This adds a batch API that also moves the decoding to the background.

This speeds up Indexing by 20-80% across my benchmark.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.51% (3f29bba) to 45.60% (3ffb420) by +0.09%.

    FilenameBase (3f29bba)Merge (3ffb420)Diff
    AsyncQueue.java78.11%77.11%-1.00%
    BackgroundQueue.java100.00%81.25%-18.75%
    DeleteMutation.java90.00%95.00%+5.00%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%
    SQLiteDocumentOverlayCache.java96.72%97.83%+1.10%
    SQLiteRemoteDocumentCache.java96.64%98.17%+1.53%

Test Logs

Notes

  • Commit (3ffb420) is created by Prow via merging PR base commit (3f29bba) and head commit (b95c5b9).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WwJ4QIuQ6t.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (3f29bba)Merge (3ffb420)Diff
    aar1.24 MB1.24 MB+1.87 kB (+0.2%)
    apk (release)3.33 MB3.33 MB+1.72 kB (+0.1%)

Test Logs

Notes

  • Commit (3ffb420) is created by Prow via merging PR base commit (3f29bba) and head commit (b95c5b9).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9O9DDMGign.html

dconeybe
dconeybe requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review and had a couple of immediate suggestions. I'll need to sit on it and review it properly tomorrow.

@schmidt-sebastian schmidt-sebastian removed their assignment Feb 9, 2022
dconeybe
dconeybe requested changes Feb 10, 2022
View reviewed changes
@dconeybe dconeybe removed their assignment Feb 10, 2022
@schmidt-sebastian schmidt-sebastian merged commit ee6e656 into master Feb 10, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/overlaybatches branch February 10, 2022 20:16
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
@schmidt-sebastian @qdpham13
Parse Overlays in background (#3420)
4a6a1f3
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@schmidt-sebastian @jeremyjiang-dev
Parse Overlays in background (#3420)
2e94f54
@firebase firebase locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @dconeybe