Skip to content

Stop image download by canceling a Future. #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

Stop image download by canceling a Future. #3426

merged 1 commit into from
Feb 9, 2022

Conversation

gsakakihara
Copy link
Contributor

@gsakakihara
Stop image download by canceling a Future.
1ff01e5 
- Switched to stopping an image download by canceling a Future to interrupt the download thread instead of trying to close the InputStream directly since the underlying library does not appear to be thread safe and can throw a variety of Exceptions when close is called on a different thread (#1830 for a previous issue).
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 85.40% (055df3e) to 85.51% (7f30f13) by +0.11%.

    FilenameBase (055df3e)Merge (7f30f13)Diff
    ImageDownload.java87.18%93.33%+6.15%

Test Logs

Notes

  • Commit (7f30f13) is created by Prow via merging PR base commit (055df3e) and head commit (1ff01e5).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zZqEb6VyIF.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (055df3e)Merge (7f30f13)Diff
    aar221 kB221 kB+197 B (+0.1%)
    apk (aggressive)547 kB547 kB-148 B (-0.0%)
    apk (release)2.46 MB2.46 MB-48 B (-0.0%)

Test Logs

Notes

  • Commit (7f30f13) is created by Prow via merging PR base commit (055df3e) and head commit (1ff01e5).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rLJNyLamMH.html

@gsakakihara gsakakihara merged commit 3f29bba into master Feb 9, 2022
@gsakakihara gsakakihara deleted the gsakakihara/cancel_image_download branch February 9, 2022 21:30
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
@gsakakihara @qdpham13
Stop image download by canceling a Future. (#3426)
2229e0d 
- Switched to stopping an image download by canceling a Future to interrupt the download thread instead of trying to close the InputStream directly since the underlying library does not appear to be thread safe and can throw a variety of Exceptions when close is called on a different thread (#1830 for a previous issue).
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@gsakakihara @jeremyjiang-dev
Stop image download by canceling a Future. (#3426)
66e5d59 
- Switched to stopping an image download by canceling a Future to interrupt the download thread instead of trying to close the InputStream directly since the underlying library does not appear to be thread safe and can throw a variety of Exceptions when close is called on a different thread (#1830 for a previous issue).
@firebase firebase locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willxu-google willxu-google willxu-google approved these changes

@welishr welishr Awaiting requested review from welishr

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsakakihara @google-oss-bot @willxu-google