Skip to content

Log notification open after onActivityCreated() on Android 7.0 and ea… #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

Log notification open after onActivityCreated() on Android 7.0 and ea… #3432

merged 1 commit into from
Feb 14, 2022

Conversation

gsakakihara
Copy link
Contributor

…rlier.

#3090

  • Switched to log notification open after onActivityCreated() has completed on Android 7.0 and earlier since unparceling a Bundle is not thread safe on those versions. This may help to avoid a race condition with anything else that may be trying to access the Intent extra Bundle from another thread started in onActivityCreated()/onCreate().

@gsakakihara
Log notification open after onActivityCreated() on Android 7.0 and ea…
45cf3d8 
…rlier.

#3090

* Switched to log notification open after onActivityCreated() has completed on Android 7.0 and earlier since unparceling a Bundle is not thread safe on those versions. This may help to avoid a race condition with anything else that may be trying to access the Intent extra Bundle from another thread started in onActivityCreated()/onCreate().
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 85.67% (d3aeffc) to 85.54% (381edaf) by -0.14%.

    FilenameBase (d3aeffc)Merge (381edaf)Diff
    FcmLifecycleCallbacks.java100.00%95.83%-4.17%
    MessagingAnalytics.java82.59%81.38%-1.21%

Test Logs

Notes

  • Commit (381edaf) is created by Prow via merging PR base commit (d3aeffc) and head commit (45cf3d8).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u6KUrKn0ia.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (d3aeffc)Merge (381edaf)Diff
    aar221 kB222 kB+466 B (+0.2%)
    apk (aggressive)547 kB547 kB+52 B (+0.0%)
    apk (release)2.46 MB2.46 MB+288 B (+0.0%)

Test Logs

Notes

  • Commit (381edaf) is created by Prow via merging PR base commit (d3aeffc) and head commit (45cf3d8).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/o7LlAEzCEi.html

@gsakakihara gsakakihara merged commit 9501fbd into master Feb 14, 2022
@gsakakihara gsakakihara deleted the gsakakihara/lifecycle_bundle branch February 14, 2022 15:29
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
@gsakakihara @qdpham13
Log notification open after onActivityCreated() on Android 7.0 and ea…
df8ff46 
…rlier. (#3432)

#3090

* Switched to log notification open after onActivityCreated() has completed on Android 7.0 and earlier since unparceling a Bundle is not thread safe on those versions. This may help to avoid a race condition with anything else that may be trying to access the Intent extra Bundle from another thread started in onActivityCreated()/onCreate().
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@gsakakihara @jeremyjiang-dev
Log notification open after onActivityCreated() on Android 7.0 and ea…
e7a22ba 
…rlier. (#3432)

#3090

* Switched to log notification open after onActivityCreated() has completed on Android 7.0 and earlier since unparceling a Bundle is not thread safe on those versions. This may help to avoid a race condition with anything else that may be trying to access the Intent extra Bundle from another thread started in onActivityCreated()/onCreate().
@firebase firebase locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willxu-google willxu-google willxu-google approved these changes

@welishr welishr Awaiting requested review from welishr

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsakakihara @google-oss-bot @willxu-google