Skip to content

Remove firebase-appdistribution-stub #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Remove firebase-appdistribution-stub #3434

merged 1 commit into from
Feb 11, 2022

Conversation

lfkellogg
Copy link
Contributor

We pivoted away from this approach.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.13% (dde5de1) to 50.18% (fff9c41) by +0.04%.

    FilenameBase (dde5de1)Merge (fff9c41)Diff
    DoubleNode.java100.00%88.24%-11.76%
    QueryParams.java89.76%90.36%+0.60%
    ViewProcessor.java91.79%92.10%+0.30%
    WebsocketConnection.java32.77%35.03%+2.26%
  • firebase-firestore

    Overall coverage changed from 45.60% (dde5de1) to 45.59% (fff9c41) by -0.00%.

    FilenameBase (dde5de1)Merge (fff9c41)Diff
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

Notes

  • Commit (fff9c41) is created by Prow via merging PR base commit (dde5de1) and head commit (a91aefb).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8jHoTGthZs.html

@lfkellogg
Copy link
Contributor Author

/test check-changed

@lfkellogg lfkellogg merged commit d936996 into master Feb 11, 2022
@lfkellogg lfkellogg deleted the lk/remove-stub branch February 11, 2022 16:06
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
@firebase firebase locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants