Prefer arrayValue when sorting FieldIndex #3435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
| if (cmp != 0) return cmp; | ||
|
|
||
| return nullSafeCompare(getArrayValue(), other.getArrayValue(), Util::compareByteArrays); | ||
| return compareByteArrays(getDirectionalValue(), other.getDirectionalValue()); |
There was a problem hiding this comment.
ArrayValue is not nullable anymore
wu-hui
approved these changes
Feb 11, 2022
qdpham13
pushed a commit
that referenced
this pull request
Feb 15, 2022
jeremyjiang-dev
pushed a commit
that referenced
this pull request
Mar 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema is
index_id, uid, array_value, directional_value, document_key. Our internal order should match this.