Skip to content

Remove canServeFromIndex #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2022
Merged

Remove canServeFromIndex #3444

merged 1 commit into from
Feb 16, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 14, 2022 •
edited
Loading

This reduces the number of times TargetIndexMatcher has to be invoked and hence reduces the number of reads from IndexedDB in the Web port.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 14, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.59% (c374dbe) to 45.58% (a7356f7) by -0.01%.

    FilenameBase (c374dbe)Merge (a7356f7)Diff
    AsyncQueue.java77.11%78.11%+1.00%
    MemoryIndexManager.java66.67%68.97%+2.30%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.14%94.29%-2.86%
    SQLiteIndexManager.java98.69%98.68%-0.02%
    Target.java96.04%96.00%-0.04%

Test Logs

Notes

  • Commit (a7356f7) is created by Prow via merging PR base commit (c374dbe) and head commit (601f001).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/c1a4AE0TAl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 14, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (c374dbe)Merge (a7356f7)Diff
    aar1.24 MB1.24 MB-320 B (-0.0%)
    apk (release)3.37 MB3.37 MB-172 B (-0.0%)

Test Logs

Notes

  • Commit (a7356f7) is created by Prow via merging PR base commit (c374dbe) and head commit (601f001).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/le9URanSz6.html

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/nocanservefromindex branch 4 times, most recently from 913a1da to 17880f9 Compare February 14, 2022 19:00
@schmidt-sebastian schmidt-sebastian mentioned this pull request Feb 14, 2022
Merged
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/nocanservefromindex branch from 17880f9 to 601f001 Compare February 15, 2022 16:39
@schmidt-sebastian schmidt-sebastian mentioned this pull request Feb 15, 2022
Merged
@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 16, 2022
@schmidt-sebastian schmidt-sebastian merged commit 6e96da6 into master Feb 16, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/nocanservefromindex branch February 16, 2022 16:40
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@schmidt-sebastian @jeremyjiang-dev
Backport indexing changes (#3444)
2fd8b0c
@firebase firebase locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui