Skip to content

Support backgrounding browser during sign in on Android 10 and below #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2022
Merged

Support backgrounding browser during sign in on Android 10 and below #3450

merged 1 commit into from
Feb 15, 2022

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 76.47% (2cfad19) to 76.43% (fa444e2) by -0.03%.

    FilenameBase (2cfad19)Merge (fa444e2)Diff
    TesterSignInManager.java93.75%93.62%-0.13%

Test Logs

Notes

  • Commit (fa444e2) is created by Prow via merging PR base commit (2cfad19) and head commit (72a0e14).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kiDJGmeTnm.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (2cfad19)Merge (fa444e2)Diff
    aar123 kB123 kB-12 B (-0.0%)
    apk (release)1.57 MB1.57 MB+52 B (+0.0%)

Test Logs

Notes

  • Commit (fa444e2) is created by Prow via merging PR base commit (2cfad19) and head commit (72a0e14).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/plpreGMMRI.html

@lfkellogg lfkellogg merged commit 5d7b787 into master Feb 15, 2022
@lfkellogg lfkellogg deleted the lk/no-history branch February 15, 2022 21:26
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
@lfkellogg @qdpham13
Support backgrounding browser during sign in on Android 10 and below (#…
40854a3 
…3450)
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@lfkellogg @jeremyjiang-dev
Support backgrounding browser during sign in on Android 10 and below (#…
51814cd 
…3450)
@firebase firebase locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachaprince rachaprince rachaprince approved these changes

@manny-jimenez manny-jimenez manny-jimenez approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfkellogg @google-oss-bot @rachaprince @manny-jimenez