Skip to content

Revert "[firehorn] Workaround to make smoke-test pass. (#3531)" #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Mar 16, 2022

This reverts #3531 .

#3531 was a workaround for #3526 . Now that the issue was fixed, the workaround is no longer needed.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (ea5490c) to 50.17% (b3ed1c3) by -0.01%.

    FilenameBase (ea5490c)Merge (b3ed1c3)Diff
    BooleanNode.java100.00%92.31%-7.69%
  • firebase-firestore

    Overall coverage changed from 45.65% (ea5490c) to 45.66% (b3ed1c3) by +0.01%.

    FilenameBase (ea5490c)Merge (b3ed1c3)Diff
    DeleteMutation.java90.00%95.00%+5.00%
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

Notes

  • Commit (b3ed1c3) is created by Prow via merging PR base commit (ea5490c) and head commit (2df869a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bTPpVTEMhD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2022

@yifanyang yifanyang force-pushed the yifany/revert-fcm-workaround branch from 3b1a68c to 2df869a Compare March 18, 2022 00:26
@yifanyang
Copy link
Contributor Author

/retest

2 similar comments
@yifanyang
Copy link
Contributor Author

/retest

@yifanyang
Copy link
Contributor Author

/retest

@yifanyang yifanyang requested a review from rlazo March 24, 2022 16:36
@yifanyang yifanyang merged commit 10fb9b2 into master Mar 24, 2022
@yifanyang yifanyang deleted the yifany/revert-fcm-workaround branch March 24, 2022 17:00
@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 2df869a link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants