Skip to content

Upgrade numpy version to 1.23.1 #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Upgrade numpy version to 1.23.1 #3955

merged 1 commit into from
Aug 2, 2022

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Jul 29, 2022

Current numpy version does not support arm64 m1 macos. Support is added in 1.21.0.

Numpy support for macos arm64 is added in 1.21.0.
See numpy/numpy#1517 for more detail.
@github-actions
Copy link
Contributor

Unit Test Results

   391 files  ±0     391 suites  ±0   16m 25s ⏱️ +3s
4 697 tests ±0  4 673 ✔️ +1  22 💤 ±0  2  - 1 
4 713 runs  ±0  4 689 ✔️ +1  22 💤 ±0  2  - 1 

For more details on these failures, see this check.

Results for commit dd5d8f7. ± Comparison against base commit d4fd4a8.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (d4fd4a8) to 50.16% (11dca8c) by -0.02%.

    FilenameBase (d4fd4a8)Merge (11dca8c)Diff
    DoubleNode.java100.00%88.24%-11.76%
  • firebase-firestore

    Overall coverage changed from 45.92% (d4fd4a8) to 45.92% (11dca8c) by +0.00%.

    FilenameBase (d4fd4a8)Merge (11dca8c)Diff
    PatchMutation.java98.39%100.00%+1.61%
  • firebase-messaging

    Overall coverage changed from 85.07% (d4fd4a8) to 85.03% (11dca8c) by -0.04%.

    FilenameBase (d4fd4a8)Merge (11dca8c)Diff
    FirebaseMessaging.java75.33%74.89%-0.44%
  • firebase-perf

    Overall coverage changed from 71.38% (d4fd4a8) to 71.35% (11dca8c) by -0.03%.

    FilenameBase (d4fd4a8)Merge (11dca8c)Diff
    TransportManager.java94.88%93.95%-0.93%

Test Logs

Notes

  • Commit (11dca8c) is created by Prow via merging PR base commit (d4fd4a8) and head commit (dd5d8f7).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/h95X6qNHdQ.html

@google-oss-bot
Copy link
Contributor

@yifanyang yifanyang changed the title Upgrade numpy version to make fireci buildable on Apple M1 chips. Upgrade numpy version to 1.23.1 Jul 29, 2022
@yifanyang yifanyang requested a review from vkryachko August 1, 2022 17:26
@yifanyang yifanyang merged commit 4bd380f into master Aug 2, 2022
@yifanyang yifanyang deleted the yifany/numpy branch August 2, 2022 16:07
lfkellogg pushed a commit that referenced this pull request Aug 5, 2022
Numpy support for macos arm64 is added in 1.21.0.
@firebase firebase locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants