Skip to content

Clean up code in IndexBackfiller #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

cherylEnkidu
Copy link
Contributor

#no-changelog

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/IndexBackfillerBackport branch from 9dd3170 to e1bb34c Compare August 2, 2022 17:27
@cherylEnkidu cherylEnkidu requested a review from wu-hui August 2, 2022 17:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 5e7746a. ± Comparison against base commit 4bd380f.

♻️ This comment has been updated with latest results.

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/IndexBackfillerBackport branch from e1bb34c to 5e7746a Compare August 2, 2022 17:33
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2022

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.91% (4bd380f) to 45.87% (9f4f7ac) by -0.04%.

    FilenameBase (4bd380f)Merge (9f4f7ac)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    GrpcCallProvider.java62.35%51.76%-10.59%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

Notes

  • Commit (9f4f7ac) is created by Prow via merging PR base commit (4bd380f) and head commit (5e7746a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FmTDLySBZl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2022

@google-oss-bot
Copy link
Contributor

@cherylEnkidu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 5e7746a link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wu-hui wu-hui assigned cherylEnkidu and unassigned wu-hui Aug 2, 2022
@cherylEnkidu cherylEnkidu merged commit 8cc5d4a into master Aug 2, 2022
@cherylEnkidu cherylEnkidu deleted the cheryllin/IndexBackfillerBackport branch August 2, 2022 19:06
lfkellogg pushed a commit that referenced this pull request Aug 5, 2022
@firebase firebase locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants