Skip to content

Fix transport telemetry support #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2022
Merged

Fix transport telemetry support #3964

merged 2 commits into from
Aug 8, 2022

Conversation

emilypgoogle
Copy link
Collaborator

Changes telemetry events to not require unmetered network and idle device to only requiring idle device as many devices never meet this criteria. Changes SQLiteEventStore.loadBatches to add events of different priority if there is space to fill in the request. Overall should make telemetry much more likely to be sent to the sever, as well as reducing requests by batching different priorities together.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022 •
edited
Loading

Unit Test Results

  60 files   -    222    60 suites   - 222   5m 14s ⏱️ - 7m 42s
792 tests  - 2 460  792 ✔️  - 2 437  0 💤  - 21  0 ❌  - 2 
792 runs   - 2 472  792 ✔️  - 2 449  0 💤  - 21  0 ❌  - 2 

Results for commit 7fe005a. ± Comparison against base commit 54e2b0c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 3, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • transport-runtime

    Overall coverage changed from 55.25% (54e2b0c) to 55.45% (67f994a) by +0.20%.

    FilenameBase (54e2b0c)Merge (67f994a)Diff
    SQLiteEventStore.java36.98%38.42%+1.44%

Test Logs

Notes

  • Commit (67f994a) is created by Prow via merging PR base commit (54e2b0c) and head commit (7fe005a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0Wda8eKUnb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 3, 2022 •
edited
Loading

Size Report 1

Affected Products

  • transport-runtime

    TypeBase (54e2b0c)Merge (67f994a)Diff
    aar178 kB179 kB+318 B (+0.2%)
    apk (aggressive)43.9 kB44.1 kB+216 B (+0.5%)
    apk (release)82.9 kB82.9 kB+52 B (+0.1%)

Test Logs

Notes

  • Commit (67f994a) is created by Prow via merging PR base commit (54e2b0c) and head commit (7fe005a).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/d3WwMAuhiQ.html

@emilypgoogle emilypgoogle requested a review from vkryachko August 4, 2022 17:42
@vkryachko
Copy link
Member

@emilypgoogle looks like your PR was created before @yifanyang fixed CI on master in #3961 . Can you please merge/rebase with the current master?

vkryachko
vkryachko previously approved these changes Aug 4, 2022
View reviewed changes
@vkryachko vkryachko dismissed their stale review August 5, 2022 15:00

removing approval pending rebase to have CI run successfully

@emilypgoogle emilypgoogle requested a review from vkryachko August 5, 2022 16:53
@emilypgoogle emilypgoogle merged commit af2a520 into master Aug 8, 2022
@emilypgoogle emilypgoogle deleted the ep/telemetry-support branch August 8, 2022 16:50
@emilypgoogle emilypgoogle restored the ep/telemetry-support branch August 11, 2022 16:56
@firebase firebase locked and limited conversation to collaborators Sep 8, 2022
@kaibolay kaibolay deleted the ep/telemetry-support branch September 15, 2022 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilypgoogle @google-oss-bot @vkryachko