Skip to content

Add workflow definition for fireperf end-to-end tests #3969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2022
Merged

Add workflow definition for fireperf end-to-end tests #3969

merged 6 commits into from
Aug 11, 2022

Conversation

yifanyang
Copy link
Contributor

No description provided.

@yifanyang yifanyang force-pushed the yifany/gha-migration-fireperf-e2e branch from 4e1c4c0 to 7d69fab Compare August 4, 2022 20:08
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.85% (089c828) to 45.80% (dde3a5e) by -0.05%.

    FilenameBase (089c828)Merge (dde3a5e)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    GrpcCallProvider.java62.35%48.24%-14.12%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%

  • firebase-perf

    Overall coverage changed from 71.37% (089c828) to 71.40% (dde3a5e) by +0.03%.

    FilenameBase (089c828)Merge (dde3a5e)Diff
    TransportManager.java93.95%94.88%+0.93%

  • firebase-storage

    Overall coverage changed from 85.81% (089c828) to 85.85% (dde3a5e) by +0.04%.

    FilenameBase (089c828)Merge (dde3a5e)Diff
    UploadTask.java80.22%80.58%+0.36%

Test Logs

Notes

  • Commit (dde3a5e) is created by Prow via merging PR base commit (089c828) and head commit (0dece9d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zVUwDWktU5.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited
Loading

Unit Test Results

   387 files  +   245     387 suites  +245   16m 11s ⏱️ + 8m 12s
4 688 tests +2 403  4 666 ✔️ +2 384  22 💤 +20  0 ❌  - 1 
4 704 runs  +2 419  4 682 ✔️ +2 400  22 💤 +20  0 ❌  - 1 

Results for commit 0dece9d. ± Comparison against base commit c6cc8c5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (089c828) and merge commit (dde3a5e).

Test Logs

Notes

  • Commit (dde3a5e) is created by Prow via merging PR base commit (089c828) and head commit (0dece9d).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eH2i4f3ZwB.html

@yifanyang yifanyang force-pushed the yifany/gha-migration-fireperf-e2e branch from f1399cc to 08532d1 Compare August 4, 2022 23:08
@yifanyang yifanyang requested a review from vkryachko August 5, 2022 00:08
@yifanyang
Copy link
Contributor Author

@vkryachko A successful execution of this workflow can be found at https://github.com/firebase/firebase-android-sdk/actions/runs/2800178050.

vkryachko
vkryachko reviewed Aug 5, 2022
View reviewed changes
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

It's unclear to me how notifications will work though, afaict you will be the one getting failure notifications, not the fireperf team. wdyt?

@yifanyang yifanyang force-pushed the yifany/gha-migration-fireperf-e2e branch from 55d996b to 8befeae Compare August 10, 2022 00:08
@yifanyang yifanyang force-pushed the yifany/gha-migration-fireperf-e2e branch from 45efeef to 006d3bb Compare August 11, 2022 16:49
@yifanyang
Copy link
Contributor Author

LGTM overall.

It's unclear to me how notifications will work though, afaict you will be the one getting failure notifications, not the fireperf team. wdyt?

Added the last step that create/update issue to notify fireperf folks. Here is an example issue #3977.

I have removed the pull_request trigger, therefore the tests did not run for last commit. Successful runs can be found at:

@vkryachko vkryachko self-requested a review August 11, 2022 20:10
@vkryachko vkryachko removed their assignment Aug 11, 2022
vkryachko
vkryachko reviewed Aug 11, 2022
View reviewed changes
.github/workflows/fireperf-e2e.yml Outdated
title: 'FirePerf E2E Test Failures',
body: text,
labels: ['fireperf-e2e-tests'],
assignees: ['jeremyjiang-dev', 'leotianlizhan', 'visumickey']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @jeremyjiang-dev @leotianlizhan @visumickey does that look good to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add @raymondlam ? LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yifanyang yifanyang merged commit 8c6788e into master Aug 11, 2022
@yifanyang yifanyang deleted the yifany/gha-migration-fireperf-e2e branch August 11, 2022 21:47
@firebase firebase locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev left review comments

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @vkryachko @jeremyjiang-dev