Firestore: QueryTest.java: improve the test that resumes a query with existence filter to actually validate the existence filter. #4813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… existence filter to actually validate the existence filter. This is a port of firebase/firebase-js-sdk#7149, and builds upon the test added in #4799.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
milaGGL
reviewed
Mar 23, 2023
...re/src/main/java/com/google/firebase/firestore/remote/WatchChangeAggregatorTestingHooks.java
Outdated
Show resolved
Hide resolved
milaGGL
reviewed
Mar 23, 2023
...re/src/main/java/com/google/firebase/firestore/remote/WatchChangeAggregatorTestingHooks.java
Outdated
Show resolved
Hide resolved
…ChangeAggregatorTestingHooksAccessor -> ExistenceFilterMismatchListener
…nage the registered ExistenceFilterMismatchListener objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the test resumingAQueryShouldUseExistenceFilterToDetectDeletes() in QueryTest.java, which was added by the previous PR #4799, to also validate that the existence filter sent from Watch was correct. This was achieved by adding some test-only "hooks" into the SDK's internals that enable the test to "listen" for existence filter mismatches. This is a port of firebase/firebase-js-sdk#7149 and firebase/firebase-ios-sdk#11209.