Skip to content

Add Firebase AI to BoM #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Add Firebase AI to BoM #6920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0ef56
Update PublishingPlugin.kt
daymxn Apr 29, 2025
9b17951
formatting
daymxn Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/src/main/java/com/google/firebase/gradle/plugins/PostReleasePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ class PostReleasePlugin : Plugin<Project> {
fun registerVersionBumpTask(project: Project) =
project.tasks.register<VersionBumpTask>("versionBump") {
// TODO(b/285892320): Remove condition when bug fixed
bumpVersion.set(project.firebaseLibrary.artifactId.map {
it !== "protolite-well-known-types"
})
bumpVersion.set(
project.firebaseLibrary.artifactId.map { it !== "protolite-well-known-types" }
)
}

/**
Expand Down
2 changes: 2 additions & 0 deletions plugins/src/main/java/com/google/firebase/gradle/plugins/PublishingPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ abstract class PublishingPlugin : Plugin<Project> {
"com.google.firebase:firebase-crashlytics",
"com.google.firebase:firebase-perf",
"com.google.firebase:firebase-vertexai",
"com.google.firebase:firebase-ai",
"com.google.firebase:firebase-messaging",
"com.google.firebase:firebase-auth",
"com.google.firebase:firebase-database",
Expand Down Expand Up @@ -816,6 +817,7 @@ abstract class PublishingPlugin : Plugin<Project> {
"com.google.firebase:firebase-storage",
"com.google.firebase:firebase-storage-ktx",
"com.google.firebase:firebase-vertexai",
"com.google.firebase:firebase-ai",
)

/** Artifacts that we use in the tutorial bundle, but _not_ in the bom. */
Expand Down
6 changes: 4 additions & 2 deletions plugins/src/main/java/com/google/firebase/gradle/plugins/VersionBumpTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ import org.gradle.kotlin.dsl.provideDelegate
* version.
* @property newVersion A [ModuleVersion] of what to set the version to. Defaults to one patch
* higher than [releasedVersion].
* @property bumpVersion If set, then the default provided by [newVersion] will be bumped by one patch. Defaults to `true`.
* @property bumpVersion If set, then the default provided by [newVersion] will be bumped by one
* patch. Defaults to `true`.
* @see PostReleasePlugin
*/
abstract class VersionBumpTask : DefaultTask() {
Expand All @@ -63,7 +64,8 @@ abstract class VersionBumpTask : DefaultTask() {
@TaskAction
fun build() {
val latestVersion = releasedVersion.get()
val version = newVersion.orNull ?: if(bumpVersion.get()) latestVersion.bump() else latestVersion
val version =
newVersion.orNull ?: if (bumpVersion.get()) latestVersion.bump() else latestVersion

versionFile.get().asFile.rewriteLines {
when {
Expand Down
Loading