Skip to content

Commit 0859b17

Browse files
authored
Update to June 2022 release of boringssl. (#1362)
* Update to Dec 2022 release of boringssl. In this release, the "src" directory is removed from boringssl, so there are some CMake and patch changes necessary for compatibility. * Re-add patch file. * Remove debug output
1 parent 71e8a1e commit 0859b17

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ if(DESKTOP)
264264

265265
if(FIREBASE_USE_BORINGSSL)
266266
# Use BoringSSL instead of OpenSSL.
267-
set(BORINGSSL_ROOT_DIR ${PROJECT_BINARY_DIR}/external/src/boringssl/src CACHE STRING "" FORCE)
267+
set(BORINGSSL_ROOT_DIR ${PROJECT_BINARY_DIR}/external/src/boringssl CACHE STRING "" FORCE)
268268
set(BORINGSSL_BINARY_DIR ${PROJECT_BINARY_DIR}/external/src/boringssl-build CACHE STRING "" FORCE)
269269
set(OPENSSL_ROOT_DIR ${BORINGSSL_ROOT_DIR} CACHE STRING "" FORCE)
270270

cmake/external/boringssl.cmake

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@ if(TARGET boringssl OR NOT DOWNLOAD_BORINGSSL)
1818
return()
1919
endif()
2020

21-
set(patch_file
22-
${CMAKE_CURRENT_LIST_DIR}/../../scripts/git/patches/boringssl/0001-disable-warnings.patch)
21+
set(patch_file ${CMAKE_CURRENT_LIST_DIR}/../../scripts/git/patches/boringssl/0001-disable-warnings.patch)
2322

24-
set(boringssl_commit_tag 83da28a68f32023fd3b95a8ae94991a07b1f6c62)
23+
set(boringssl_commit_tag fips-20220613)
2524

2625
ExternalProject_Add(
2726
boringssl

cmake/external_rules.cmake

+5-5
Original file line numberDiff line numberDiff line change
@@ -112,17 +112,17 @@ function(download_external_sources)
112112
if (FIREBASE_USE_BORINGSSL)
113113
# CMake's find_package(OpenSSL) doesn't quite work right with BoringSSL
114114
# unless the header file contains OPENSSL_VERSION_NUMBER.
115-
file(READ ${PROJECT_BINARY_DIR}/external/src/boringssl/src/include/openssl/opensslv.h TMP_HEADER_CONTENTS)
115+
file(READ ${PROJECT_BINARY_DIR}/external/src/boringssl/include/openssl/opensslv.h TMP_HEADER_CONTENTS)
116116
if (NOT TMP_HEADER_CONTENTS MATCHES OPENSSL_VERSION_NUMBER)
117-
file(APPEND ${PROJECT_BINARY_DIR}/external/src/boringssl/src/include/openssl/opensslv.h
117+
file(APPEND ${PROJECT_BINARY_DIR}/external/src/boringssl/include/openssl/opensslv.h
118118
"\n#ifndef OPENSSL_VERSION_NUMBER\n# define OPENSSL_VERSION_NUMBER 0x10010107L\n#endif\n")
119119
endif()
120120
# Also add an #include <stdlib.h> since openssl has it and boringssl
121121
# doesn't, and some of our code depends on the transitive dependency (this
122122
# is a bug).
123-
file(READ ${PROJECT_BINARY_DIR}/external/src/boringssl/src/include/openssl/rand.h TMP_HEADER2_CONTENTS)
123+
file(READ ${PROJECT_BINARY_DIR}/external/src/boringssl/include/openssl/rand.h TMP_HEADER2_CONTENTS)
124124
if (NOT TMP_HEADER2_CONTENTS MATCHES "<stdlib.h>")
125-
file(APPEND ${PROJECT_BINARY_DIR}/external/src/boringssl/src/include/openssl/rand.h
125+
file(APPEND ${PROJECT_BINARY_DIR}/external/src/boringssl/include/openssl/rand.h
126126
"\n#include <stdlib.h>\n")
127127
endif()
128128
endif()
@@ -241,7 +241,7 @@ function(build_external_dependencies)
241241
if(NOT ANDROID AND NOT IOS)
242242
if (FIREBASE_USE_BORINGSSL)
243243
execute_process(
244-
COMMAND ${ENV_COMMAND} cmake -DOPENSSL_NO_ASM=TRUE ${CMAKE_SUB_CONFIGURE_OPTIONS} ../boringssl/src
244+
COMMAND ${ENV_COMMAND} cmake -DOPENSSL_NO_ASM=TRUE ${CMAKE_SUB_CONFIGURE_OPTIONS} ../boringssl
245245
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/external/src/boringssl-build
246246
RESULT_VARIABLE boringssl_configure_status
247247
)

scripts/git/patches/boringssl/0001-disable-warnings.patch

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
--- a/src/CMakeLists.txt
2-
+++ b/src/CMakeLists.txt
3-
@@ -193,6 +193,11 @@ elseif(MSVC)
1+
--- a/CMakeLists.txt
2+
+++ b/CMakeLists.txt
3+
@@ -197,6 +197,11 @@ elseif(MSVC)
44
# possible loss of data
55
"C4244" # 'function' : conversion from 'int' to 'uint8_t',
66
# possible loss of data

0 commit comments

Comments
 (0)