Skip to content

Update to June 2022 release of boringssl. #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 26, 2023

In this release, the "src" directory is removed from boringssl, so there are some CMake and patch changes necessary for compatibility.

Description

Provide details of the change, and generalize the change in the PR title above.

There are a number of issues with newer Xcode and other compilers that are fixed in newer boringssl releases. This updates to the last 2022 release (from a 2019 version used before).


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running expanded integration tests in this PR. Also running packaging workflow and tests


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

In this release, the "src" directory is removed from boringssl,
so there are some CMake and patch changes necessary for compatibility.
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 26, 2023
@jonsimantov jonsimantov requested a review from a-maurice June 27, 2023 01:00
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jun 27, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit 0859b17
Last updated: Wed Jun 28 15:10 PDT 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
gma [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov changed the title Update to Dec 2022 release of boringssl. Update to June 2022 release of boringssl. Jun 27, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 27, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jun 27, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jun 27, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) June 28, 2023 18:31
@jonsimantov jonsimantov merged commit 0859b17 into main Jun 28, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 28, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@firebase firebase locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants