Skip to content

Fix bash typo in integration_tests.yml #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

Fix bash typo in integration_tests.yml #1023

merged 2 commits into from
Jul 13, 2022

Conversation

dconeybe
Copy link
Contributor

Fix fixes the following error:

D:\a\_temp\06929eb0-6b9b-4afe-ae47-9ae8117d8f0e.sh: line 2: [: missing `]'

e.g. https://github.com/firebase/firebase-cpp-sdk/runs/7301198906

@dconeybe dconeybe added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jul 13, 2022
@dconeybe dconeybe requested a review from sunmou99 July 13, 2022 04:44
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 13, 2022
@github-actions
Copy link

github-actions bot commented Jul 13, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @dconeybe on commit 059dbac
Last updated: Wed Jul 13 14:50 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_target]
database [TEST] [ERROR] [Windows] [x64] [openssl]
firestore [TEST] [ERROR] [Windows] [x64] [openssl]
gma [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 13, 2022
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Jul 13, 2022
sunmou99
sunmou99 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@dconeybe dconeybe merged commit 059dbac into main Jul 13, 2022
@dconeybe dconeybe deleted the dconeybe/IntegrationTestsBashTypoFix branch July 13, 2022 17:10
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jul 13, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 13, 2022
@firebase firebase locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees

@sunmou99 sunmou99

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @sunmou99