Skip to content

Patch sprintf in uWebsockets to use snprintf #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Dec 9, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

The latest Xcode tools have deprecated the use of sprintf. Use of that functions now produces warnings, and our builds treat such warnings as errors.

uWebSockets uses sprintf in one location.

This change updates the git patch that we already apply to uWebSockets sources to also update its use of sprintf to use snprintf instead. Thankfully, the size of the buffer that sprintf was writing into was readily available.

Note: we can't push this change back to uWebSockets as they've since rewritten the library.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration CI
Packaged Build -> Integration CI


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review December 9, 2022 01:15
@DellaBitta DellaBitta added the skip-release-notes Skip release notes check label Dec 9, 2022
@DellaBitta DellaBitta merged commit b4f9e0b into main Dec 9, 2022
@DellaBitta DellaBitta deleted the ddb/uWebSockets_snprintf branch December 9, 2022 19:06
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

❌  Integration test FAILED

Requested by @DellaBitta on commit b4f9e0b
Last updated: Fri Dec 9 13:58 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
[TEST] [FLAKINESS] [Android] [2/3 os: ubuntu windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 9, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 9, 2022
@firebase firebase locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants