Patch sprintf in uWebsockets to use snprintf #1164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest Xcode tools have deprecated the use of
sprintf
. Use of that functions now produces warnings, and our builds treat such warnings as errors.uWebSockets uses
sprintf
in one location.This change updates the git patch that we already apply to uWebSockets sources to also update its use of
sprintf
to usesnprintf
instead. Thankfully, the size of the buffer that sprintf was writing into was readily available.Note: we can't push this change back to uWebSockets as they've since rewritten the library.
Testing
Integration CI
Packaged Build -> Integration CI
Type of Change
Place an
x
the applicable box: