Skip to content

Add App Check hooks for desktop rest calls #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 14, 2023
Merged

Add App Check hooks for desktop rest calls #1198

merged 7 commits into from
Feb 14, 2023

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add the necessary logic to retrieve a token that can be used by the internal products to add to their rest calls. Also adds it to storage, along with adding storage to the app check testapp.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Feb 1, 2023
@a-maurice a-maurice requested a review from AlmostMatt February 8, 2023 21:34
@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Feb 8, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @a-maurice on commit 03b8d7e
Last updated: Tue Feb 14 17:13 PST 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: android_target]
[TEST] [FAILURE] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  SourceTest.GetNonExistingCollectionWhileOnlineWithSourceEqualToServer

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 9, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 9, 2023
AlmostMatt
AlmostMatt requested changes Feb 10, 2023
View reviewed changes
@a-maurice a-maurice merged commit 03b8d7e into main Feb 14, 2023
@a-maurice a-maurice deleted the am-app_check_desktop branch February 14, 2023 22:25
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 14, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 15, 2023
chkuang-g pushed a commit that referenced this pull request Feb 24, 2023
@a-maurice @chkuang-g
Add App Check hooks for desktop rest calls (#1198)
ef321a2 
* Add App Check hooks for desktop

* Formatting

* Update comments

* Fix include problems

* Update based on feedback

* Update file format
@firebase firebase locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @AlmostMatt