Skip to content

Update to C++14. #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 25, 2023
Merged

Update to C++14. #1250

merged 11 commits into from
Apr 25, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 29, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

The last release added a warning when building with older versions of C++ such as C++11. This update (which will be released with the next major version) changes the C++ build to use the C++14 standard, and removes the warning added in the previous release.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration tests - a few known flakes / errors. Packaging has also been run and succeeded.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 29, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 29, 2023
@github-actions
Copy link

github-actions bot commented Mar 29, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 7f5a572
Last updated: Tue Apr 25 15:10 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

dconeybe
dconeybe reviewed Mar 29, 2023
View reviewed changes
CMakeLists.txt
@@ -16,7 +16,7 @@

cmake_minimum_required (VERSION 3.1)

set (CMAKE_CXX_STANDARD 11)
set (CMAKE_CXX_STANDARD 14)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment: Should we add set (CMAKE_CXX_STANDARD_REQUIRED YES) also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 29, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 29, 2023
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Mar 29, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: succeeded This PR's integration tests succeeded. labels Mar 29, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 29, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Mar 30, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 30, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Mar 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 30, 2023
@jonsimantov
Copy link
Contributor Author

jonsimantov commented Mar 31, 2023 •
edited
Loading

Firestore Android build is broken by this update: log here - give it a moment to load, the log file is large

@cherylEnkidu

@jonsimantov jonsimantov enabled auto-merge (squash) April 24, 2023 18:41
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 24, 2023
@jonsimantov jonsimantov disabled auto-merge April 24, 2023 18:48
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 24, 2023
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Apr 24, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) April 24, 2023 18:58
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 24, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 25, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 25, 2023
@jonsimantov jonsimantov added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Apr 25, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 25, 2023
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Apr 25, 2023
@jonsimantov jonsimantov merged commit 7f5a572 into main Apr 25, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 25, 2023
@jonsimantov jonsimantov deleted the cpp14 branch April 25, 2023 18:57
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 25, 2023
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe left review comments

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

@cherylEnkidu cherylEnkidu

Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonsimantov @dconeybe @wu-hui @a-maurice @cherylEnkidu